Fixed false positive charge skill hitTime logs

Charge skills boosted by cast speed would lose their boost, depending on the cast duration
beyond-aion · Nov 11, 2024 · b96b0e9 · b96b0e9
1 parent 1f9adbe
commit b96b0e9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/game-server/src/com/aionemu/gameserver/model/gameobjects/player/Player.java b/game-server/src/com/aionemu/gameserver/model/gameobjects/player/Player.java
@@ -1227,7 +1227,11 @@ public SkillTemplate getLastSkill() {
 	}
 
 	public boolean isHitTimeBoosted() {
-		return System.currentTimeMillis() <= hitTimeBoostExpireTimeMillis;
+		return isHitTimeBoosted(System.currentTimeMillis());
+	}
+
+	public boolean isHitTimeBoosted(long timeMillis) {
+		return timeMillis <= hitTimeBoostExpireTimeMillis;
 	}
 
 	public float getHitTimeBoostCastSpeed() {

diff --git a/game-server/src/com/aionemu/gameserver/skillengine/model/ChargeSkill.java b/game-server/src/com/aionemu/gameserver/skillengine/model/ChargeSkill.java
@@ -31,6 +31,9 @@ public boolean useSkill() {
 		effector.getObserveController().notifyStartSkillCastObservers(this);
 		effector.setCasting(this);
 		effector.getObserveController().attach(moveListener);
+		// motion boost state from the charge starting time must not get lost
+		if (effector instanceof Player player && player.isHitTimeBoosted(player.getCastingSkill().getCastStartTime()))
+			player.setHitTimeBoost(System.currentTimeMillis() + 100, player.getHitTimeBoostCastSpeed());
 		updateCastDurationAndSpeed();
 		updateHitTime(SecurityConfig.CHECK_ANIMATIONS);
 		endCast();