Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use scale factor for touches in UI focus #16522

Merged
merged 1 commit into from
Nov 26, 2024
Merged

use scale factor for touches in UI focus #16522

merged 1 commit into from
Nov 26, 2024

Conversation

mockersf
Copy link
Member

Objective

Solution

  • UI focus now uses the window scale factor for touches

@mockersf mockersf added A-UI Graphical user interfaces, styles, layouts, and widgets O-Android Specific to the Android mobile operating system O-iOS Specific to the iOS mobile operating system labels Nov 26, 2024
@mockersf mockersf added this to the 0.15 milestone Nov 26, 2024
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Input Player input via keyboard, mouse, gamepad, and more labels Nov 26, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 26, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 26, 2024
Merged via the queue into bevyengine:main with commit 98d433a Nov 26, 2024
35 checks passed
mockersf added a commit that referenced this pull request Nov 26, 2024
@mockersf
use scale factor for touches in UI focus (#16522)
dc0c9f3 
# Objective

- Fix the issue mentioned on iOS in
#16363 (comment)
- touch on the button in the mobile example are not detected

## Solution

- UI focus now uses the window scale factor for touches
mockersf added a commit that referenced this pull request Nov 26, 2024
@mockersf
use scale factor for touches in UI focus (#16522)
6d6fc94 
# Objective

- Fix the issue mentioned on iOS in
#16363 (comment)
- touch on the button in the mobile example are not detected

## Solution

- UI focus now uses the window scale factor for touches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@cart cart cart approved these changes

Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior O-Android Specific to the Android mobile operating system O-iOS Specific to the iOS mobile operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @cart @alice-i-cecile