0.13 migration: Use clippy-approved ReceivedCharacter advice #1045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And other improvements. I went in there to fix the clippy thing and things sort of snowballed.
Moved the text to a subsection of the PR that caused the breakage
Added some context about why it's not a
char
and what else might be in there.Added a sentence about a new alternative to
ReceivedCharacter
that folks may want to use instead.Modified the previous advice so that it is Clippy-approved.
The previous advice would result in:
Clippy suggests
.next()
, but based on the winit docs, it seems like.last()
might be the way to go to me. In the cases where there's more than one char, folks probably want the last one.Some of this stuff should probably make its way into Bevy's docs or a bevy issue.