feat(style-panel): fix some reviews

betterdancing · Nov 8, 2024 · 99ba593 · 99ba593
1 parent 8249af4
commit 99ba593
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 18 deletions.
diff --git a/packages/configurator/src/number-configurator/NumberConfigurator.vue b/packages/configurator/src/number-configurator/NumberConfigurator.vue
@@ -170,7 +170,7 @@ export default {
       text-align: left;
     }
     :deep(.is-disabled) {
-      background-color: var(--te-common-bg-default);
+      background-color: var(--te-common-bg-disabled);
     }
     &.is-without-controls {
       :deep(.tiny-numeric__input-inner) {
@@ -205,7 +205,7 @@ export default {
         display: none;
       }
       .tiny-input.is-disabled .tiny-input__inner {
-        background-color: var(--te-common-bg-disabled);
+        background-color: var(--te-common-bg-container);
       }
     }
   }

diff --git a/packages/configurator/src/tabs-group-configurator/TabsGroupConfigurator.vue b/packages/configurator/src/tabs-group-configurator/TabsGroupConfigurator.vue
@@ -103,26 +103,27 @@ import {
 } from '@opentiny/vue'
 
 const props = defineProps({
+  // tab选中值，用于默认选中的tab
   modelValue: {
     type: String,
     default: ''
   },
+  // tab选中值如果是对象，valueKey是对象内的某个key
   valueKey: {
     type: String,
     default: ''
   },
-  effect: {
-    type: String,
-    default: 'dark'
-  },
+  // 提示内容位置
   placement: {
     type: String,
     default: 'top'
   },
+  // tabItem宽度
   labelWidth: {
     type: Number,
     default: 63
   },
+  // tab的选项，如果选项中包含collapsed，则会折叠为下拉
   options: {
     type: Array,
     default: () => []

diff --git a/packages/design-core/assets/style-panel-collapsed.svg b/packages/design-core/assets/style-panel-collapsed.svg
diff --git a/packages/design-core/assets/style-panel-expand.svg b/packages/design-core/assets/style-panel-expand.svg
diff --git a/packages/layout/src/DesignSettings.vue b/packages/layout/src/DesignSettings.vue
@@ -6,7 +6,7 @@
         <div v-show="activating" class="active"></div>
       </tiny-tab-item>
     </tiny-tabs>
-    <div class="tabs-setting">
+    <div v-if="layoutState.settings.render === 'style'" class="tabs-setting">
       <tiny-tooltip effect="dark" :content="isCollapsed ? '展开' : '折叠'" placement="top" :visible-arrow="false">
         <template #default> <svg-icon :name="settingIcon" @click="isCollapsed = !isCollapsed"></svg-icon> </template>
       </tiny-tooltip>

diff --git a/packages/settings/styles/src/Main.vue b/packages/settings/styles/src/Main.vue
@@ -265,7 +265,7 @@ export default {
   display: inline-block;
   margin-left: 4px;
   vertical-align: middle;
-  border: 2px solid var(--ti-lowcode-setting-style-reset-dot-color);
+  border: 2px solid var(--te-common-border-checked);
   border-radius: 2px;
 }
 </style>
diff --git a/packages/theme/light/setting-style.less b/packages/theme/light/setting-style.less
@@ -6,8 +6,6 @@
   --ti-lowcode-setting-style-btn-border-color: var(--ti-lowcode-base-gray-90);
   --ti-lowcode-setting-style-title-color: var(--ti-lowcode-base-text-color);
   --ti-lowcode-setting-style-tab-bg-color: var(--ti-lowcode-base-bg-7);
-  --ti-lowcode-setting-style-reset-bg-color: var(--te-common-bg-primary-checked);
-  --ti-lowcode-setting-style-reset-dot-color: var(--te-common-bg-primary-checked);
   --ti-lowcode-setting-style-drag-bar-bg: var(--ti-lowcode-base-bg);
   --ti-lowcode-setting-style-spacing-bg: var(--te-base-gray-34);
 }