Add support for openvscode server #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xhochy, could you please take a look at this? |
xhochy
reviewed
Aug 18, 2023
xhochy
approved these changes
Aug 18, 2023
|
I realized we're not running CI here. Let's fix it: #40 |
Co-authored-by: Uwe L. Korn <[email protected]>
xhochy
force-pushed
the
add-support-for-openvscode-server
branch
from
cf3a886
to
593cb10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[openvscode-server[(https://github.com/gitpod-io/openvscode-server) is a popular alternative to code-server. This PR adds support for openvscode-server to this package. You can toggle between the two through the
CODE_EXECUTABLEenvironment variable.I've also added type hints to the code base in 73a5764. I can remove that if it's not wanted.