ajoute un role ARIA à la div wrapper de modale du header #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tel quel, le DOM du composant footer ne passe pas la batterie de specs de la gem AXE core sans configuration particulière
Le problème vient de la div wrapper de la modale de menu qui utilise un
aria-labelledby
alors qu’elle n’a pas de role ARIA.Cela semble être une faute et c’est remonté comme
serious
:cf la règle un peu dure à lire https://dequeuniversity.com/rules/axe/4.3/aria-allowed-attr?application=axeAPI
J’en déduis que pour utiliser
aria-labelledby
il faut unrole
, ce qu je rajoute ici.J’ai envisagé d’utiliser un
<nav>
plutôt qu’un rôlenav
mais il y a déjà une nav nestée dans la modale donc je trouve ça un peu bizarreJ’ai aussi envisagé d’utiliser le rôle
alertdialog
mais ça ne semble pas correspondre à un menu de navigation.