Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BETAFPVG473.config #1245

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Add BETAFPVG473.config #1245

merged 2 commits into from
Feb 26, 2024

Conversation

betafpv-engineer
Copy link
Contributor

Add BETAFPVG473 target

@betafpv-engineer betafpv-engineer requested a review from a team as a code owner January 26, 2024 02:03
@haslinghuis
Copy link
Member

@ot0tot baro and osd SPI are shared. Please check.

@ot0tot
Copy link
Contributor

ot0tot commented Jan 27, 2024

@ot0tot baro and osd SPI are shared. Please check.

I haven't looked into the G4 much yet, but I think this will be ok as OSD will primarily use MOSI while baro will primarily use MISO. Do you have a board to test?

@haslinghuis
Copy link
Member

No samples.

haslinghuis
haslinghuis requested changes Jan 27, 2024
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to create a target in config repo too.

configs/default/BEFH-BETAFPVG473.config Outdated Show resolved Hide resolved
configs/default/BEFH-BETAFPVG473.config Outdated Show resolved Hide resolved
@betafpv-engineer
Copy link
Contributor Author

No samples.

image
It has been tested that the baro can share an SPI with the OSD.

@sugaarK
Copy link
Member

sugaarK commented Jan 29, 2024

No samples.

image It has been tested that the baro can share an SPI with the OSD.

it leads to very poor OSD performance that because the OSD task is so system intensive, can cause issues with overall flight controller performance. we absolutely do not recommend sharing the bus with the OSD chip given its a critical system function!

@betafpv-engineer
Copy link
Contributor Author

No samples.

image It has been tested that the baro can share an SPI with the OSD.

it leads to very poor OSD performance that because the OSD task is so system intensive, can cause issues with overall flight controller performance. we absolutely do not recommend sharing the bus with the OSD chip given its a critical system function!

Is it OK for Baro and Flash to share the same SPI?

@sugaarK
Copy link
Member

sugaarK commented Jan 29, 2024

No samples.

image It has been tested that the baro can share an SPI with the OSD.

it leads to very poor OSD performance that because the OSD task is so system intensive, can cause issues with overall flight controller performance. we absolutely do not recommend sharing the bus with the OSD chip given its a critical system function!

Is it OK for Baro and Flash to share the same SPI?

@SteveCEvans ? your thoughts

@betafpv-engineer
Update BEFH-BETAFPVG473.config
9df2f00 
Baro changed to I2C 
add an led 
and modifications were made as requested
@betafpv-engineer
Copy link
Contributor Author

No samples.

image It has been tested that the baro can share an SPI with the OSD.

it leads to very poor OSD performance that because the OSD task is so system intensive, can cause issues with overall flight controller performance. we absolutely do not recommend sharing the bus with the OSD chip given its a critical system function!

Is it OK for Baro and Flash to share the same SPI?

@SteveCEvans ? your thoughts

It has been modified as requested , Baro changed to I2C.

@haslinghuis haslinghuis mentioned this pull request Feb 26, 2024
Merged
@haslinghuis haslinghuis merged commit 8eea419 into betaflight:master Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@betafpv-engineer @haslinghuis @ot0tot @sugaarK @nerdCopter @Chan-hunter