Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PULLUP(s) #515

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Aug 5, 2024

  • fixes compiling of these targets
  • unsure if they should also have #define USE_I2C_PULLUP

@nerdCopter nerdCopter marked this pull request as ready for review August 5, 2024 16:48
@ledvinap
Copy link
Contributor

ledvinap commented Aug 5, 2024

It seems that USE_I2C_PULLUP is used to enable pullups (on all ports). https://github.com/betaflight/betaflight/blob/master/src/main/target/common_defaults_post.h#L42-L52

@haslinghuis
Copy link
Member

haslinghuis commented Aug 5, 2024

All targets changed in here only use a single I2C port definition. If we want to have more control we need to change firmware instead. But won't be needed at this point ???

We also have these targets using USE_I2C_PULLUP:

configs/CCRCF435AIO/config.h:101:#define USE_I2C_PULLUP
configs/MERCURYG4/config.h:106:#define USE_I2C_PULLUP
configs/NEUTRONRCF435MINI/config.h:101:#define USE_I2C_PULLUP
configs/DARWINF435/config.h:100:#define USE_I2C_PULLUP

@nerdCopter
Copy link
Member Author

whatever ya'll want. let me know how to modify this PR.

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we fix it in firmware it will apply to firmware 4.5.2 / 4.6 only.

@ot0tot
Copy link
Contributor

ot0tot commented Aug 5, 2024

Is this needed? The internal I2C pullups are very weak, I'm not sure enabling them does anything. There should be external pullups on the FC for I2C.

@blckmn blckmn merged commit 742b429 into betaflight:master Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants