Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create IFLIGHT_BORG_F435S config.h #498

Merged
merged 11 commits into from
Sep 19, 2024
Merged

Create IFLIGHT_BORG_F435S config.h #498

merged 11 commits into from
Sep 19, 2024

Conversation

ot0tot
Copy link
Contributor

@ot0tot ot0tot commented Jul 17, 2024

Draft config for iFlight R5 AT32F435 FC

@ot0tot ot0tot marked this pull request as ready for review August 20, 2024 16:51
@ot0tot
Copy link
Contributor Author

ot0tot commented Aug 20, 2024

Actually hold off on the review here until we get some clarification from iFlight. There seems to be multiple FC designs called "R5" and I'm not sure which one this target should correspond to.

@haslinghuis haslinghuis changed the title Create iFlight R5 F435 config.h Create iFlight R5 AIO F435 config.h Aug 21, 2024
@ot0tot
Rename IFLIGHT_BORG_F435S and update target
fa91add 
iFlight requested to rename this target and provided an updated schematic
@ot0tot ot0tot changed the title Create iFlight R5 AIO F435 config.h Create IFLIGHT_BORG_F435S config.h Sep 5, 2024
haslinghuis
haslinghuis requested changes Sep 5, 2024
View reviewed changes
configs/IFLIGHT_BORG_F435S/config.h Outdated Show resolved Hide resolved
@ot0tot @haslinghuis
Fix board name
c3a7cad 
Co-authored-by: Mark Haslinghuis <[email protected]>
@nerdCopter
Copy link
Member

ready or draft?

nerdCopter
nerdCopter requested changes Sep 5, 2024
View reviewed changes
configs/IFLIGHT_BORG_F435S/config.h Outdated Show resolved Hide resolved
@ot0tot ot0tot requested a review from nerdCopter September 10, 2024 02:05
nerdCopter
nerdCopter approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different overall layout than other config.h files, but approving nonetheless

@sugaarK
Copy link
Member

sugaarK commented Sep 19, 2024

is this ready to go @ot0tot or still in draft

@ot0tot
Copy link
Contributor Author

ot0tot commented Sep 19, 2024

is this ready to go @ot0tot or still in draft

Ready to go

@sugaarK sugaarK merged commit 9984c5c into betaflight:master Sep 19, 2024
1 check passed
@ot0tot ot0tot deleted the R5-AT435 branch September 21, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@ot0tot ot0tot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ot0tot @nerdCopter @sugaarK @haslinghuis