Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLYCOLORF7* bug fixes #490

Merged
merged 5 commits into from
Jul 5, 2024
Merged

FLYCOLORF7* bug fixes #490

merged 5 commits into from
Jul 5, 2024

Conversation

tobeornottobe81
Copy link
Contributor

FLYCOLORF7_AIO: Add Definitions for Targets
FLYCOLORF7V2: Correction of MOTOR3 pin definition
FLYCOLORF7: Add BARO Definitions for Target

tobeornottobe81 and others added 5 commits May 21, 2024 11:54
Add BARO Definitions for Target
Correction of MOTOR3 pin definition
Add Definitions for Targets
@haslinghuis haslinghuis merged commit 4dfe804 into betaflight:master Jul 5, 2024
1 check passed
@nerdCopter nerdCopter changed the title bug fixes FLYCOLORF7* bug fixes Jul 8, 2024
@nerdCopter
Copy link
Member

nerdCopter commented Jul 8, 2024

i noticed FLYCOLORF7_AIO has gyro2 pins, but no GYRO_2_SPI_INSTANCE.

also, is this normal? i typically only see GYRO_1_ALIGN (where if set to CW0_DEG this is also default & not needed) and i've seen GYRO_1_ALIGN_YAW but typically do not see roll/pitch defined.

#define GYRO_1_ALIGN_ROLL 0
#define GYRO_1_ALIGN_PITCH 0
#define GYRO_1_ALIGN_YAW 0

@haslinghuis
Copy link
Member

Probably cleanup:

#define GYRO_2_EXTI_PIN      PC4
#define GYRO_2_CS_PIN        PB2

As for

#define GYRO_1_ALIGN_ROLL 0
#define GYRO_1_ALIGN_PITCH 0
#define GYRO_1_ALIGN_YAW 0

it seems to use ALIGN_DEFAULT

https://github.com/betaflight/betaflight/blob/cf6d1c1eb6aca641c5ed3b0c08b23f0769991188/src/main/common/sensor_alignment.h#L26-L42

GYRO_1_ALIGN defaults to CW0_DEG

https://github.com/betaflight/betaflight/blob/cf6d1c1eb6aca641c5ed3b0c08b23f0769991188/src/main/pg/gyrodev.c#L60-L68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants