Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'RRIOT_F722' target #480

Merged
merged 7 commits into from
Jul 27, 2024
Merged

Add 'RRIOT_F722' target #480

merged 7 commits into from
Jul 27, 2024

Conversation

ws998116
Copy link
Contributor

@ws998116 ws998116 commented Jun 26, 2024

We have completed development and testing for this board and would like to add the target config.

https://rotorriot.com/products/rotor-riot-brave-f7-flight-controller-made-in-usa

@ws998116
Copy link
Contributor Author

One issue that we've found is in the Receiver tab, the Telemetry setting shows up twice.

image

@nerdCopter nerdCopter requested a review from a team June 26, 2024 13:57
@nerdCopter
Copy link
Member

i'm not certain what causes dual telemetry toggles. please try nightly configurator https://github.com/betaflight/betaflight-configurator-nightlies/releases or https://app.betaflight.com in Chrome.

@haslinghuis
Copy link
Member

Dual telemetry shows up in case of a local build which is fixed in https://app.betaflight.com

@ot0tot
Copy link
Contributor

ot0tot commented Jun 26, 2024

  • Does this FC not have a LED_STRIP pin?

  • Target is missing gyro interrupt pin.

  • No timer for camera control pin.

Please provide the schematic in the appropriate manufacturer channel on the Betaflight Discord. Contact @sugaarK for access.

@sugaarK
Copy link
Member

sugaarK commented Jun 26, 2024

[email protected]

@ws998116
Copy link
Contributor Author

@ot0tot

  • Does this FC not have a LED_STRIP pin?

No, we do not have an LED_STRIP pin.

  • Target is missing gyro interrupt pin.

I have added the gyro interrupt pin define.

  • No timer for camera control pin.

I am having trouble adding this. The camera control pin is PC4, and I can't seem to add a timer to this pin (C04) using the CLI.

@haslinghuis
Copy link
Member

Pin C4 does not have timers.

@ws998116
Copy link
Contributor Author

No timer for camera control pin.

Pin C4 does not have timers.

Are we required to have a timer for the camera control pin?

@haslinghuis
Copy link
Member

Yes camera control seems to need a timer.

@ws998116
Copy link
Contributor Author

ws998116 commented Jul 5, 2024

We have updated our board to use a camera control pin with a timer, you can find the schematic in our Discord channel. The updated config file is here.

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend using ICM42688P instead of BMI270

@nerdCopter nerdCopter requested a review from a team July 8, 2024 12:46
@ws998116
Copy link
Contributor Author

We would love to get this approved and move forward if possible! Please let me know if there are any additional steps that I need to take. Thank you!

@nerdCopter nerdCopter requested a review from sugaarK July 16, 2024 18:54
@nerdCopter
Copy link
Member

nerdCopter commented Jul 16, 2024

off-subject. i added product link to description. while reviewing, i noticed product page says image without underscore.

configs/RRIOT_F722/config.h Outdated Show resolved Hide resolved
configs/RRIOT_F722/config.h Outdated Show resolved Hide resolved
ws998116 and others added 2 commits July 17, 2024 07:06
Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: Mark Haslinghuis <[email protected]>
@ws998116
Copy link
Contributor Author

off-subject. i added product link to description. while reviewing, i noticed product page says RRIOTF722.

Thanks for catching this @nerdCopter! Fixed on the product page.

@haslinghuis haslinghuis merged commit 6440ad8 into betaflight:master Jul 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants