Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full USE_ list #419

Closed
wants to merge 4 commits into from
Closed

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented May 8, 2024

EDIT: ctsnooze has found better grep commands and retro fitted into #418 and config.h cleanup into betaflight/config#420.
This PR should be closed, but we should retain removal of the 4.4 specificity from the API page. It should also link to his new document docs/development/Defines.md

image

https://deploy-preview-419.dev.web.betaflight.com/docs/development/API/Cloud-Build-API#other

Copy link

netlify bot commented May 8, 2024

Deploy Preview for origin-betaflight-com ready!

Name Link
🔨 Latest commit 61cbcbd
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-com/deploys/663d1e62bd816f00085ec83f
😎 Deploy Preview https://deploy-preview-419.dev.web.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nerdCopter
Copy link
Member Author

nerdCopter commented May 8, 2024

  • i'm certain too many defines here.
  • created via commit c155f5830 Mark Haslinghuis 2024-04-28 Update EEPROM version for 4.5 (#13498) and the command:
    • grep -Ir -oh "USE_[0-9A-Z_]\+" src/ | sort | uniq
  • created from master
    • grep --exclude-dir=config -Ir -w -oh "USE_[0-9A-Z_]\+" src/ | sort | uniq

@haslinghuis
Copy link
Member

@nerdCopter
Copy link
Member Author

Oh, I see, we have Other Options, and i added Other 🤪 🤦‍♂️

@nerdCopter
Copy link
Member Author

Not certain how to handle. if i move the spoiler under Other Options, such is incorrect as well.
Maybe rename ### Other to ### Full List.
and rename spoiler title to what?

@haslinghuis
Copy link
Member

### Overview

<Full List>

@nerdCopter
Copy link
Member Author

the only thing i dont like is this is under 4.4, but the list is from 4.5
image

@haslinghuis
Copy link
Member

Agree 4.4 should be removed from filename (title) here.

Also some defines were introduced in later version 😃

Copy link

sonarqubecloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nerdCopter
Copy link
Member Author

updated/fixed. still more defines than usable i believe.

@haslinghuis
Copy link
Member

haslinghuis commented May 9, 2024

Perhaps

  • mention RACE PRO was introduced in 4.5
  • OSD_QUICK_MENU, RPM LIMIT, SPEC_ARM_SCREEN were added in 4.5
  • GPS_PLUS_CODES is no longer (or have never been) a build option as it is included automatically when using USE_GPS
  • not sure about RC_STATS

@nerdCopter nerdCopter closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants