Filter roles #2
Open
Filter roles #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows loading a CSV generated from the Download Spreadsheet link from the Assets search results pages in RT. It: - Handles multiple principals. - Strips off the fullname. - Handles - ignores - usernames which don't exist (previously Nobody account was used).
This adds: - handling groups - removing users/groups which aren't in the CSV file - handling Owner (with AssetMultipleOwner on and off)
Strictly speaking only the first line needed to be changed, but I figure for consistency it is clearer if we just use $principal. ($user and $principal are pointing to the same object for the second line.)
I noticed that RT inserts "group:$group_name" in the role fields when creating an asset in the web interface. However, Download Spreadsheet uses "Group: $group_name" (this is what I initially selected to support).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request effectively adds support for loading back in the output of Bulk Download of assets. You still need to create a mapping, but this might be enough to allow an attempt at automatic mapping.
Adds support for: