Pull this revised Sybase code #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I will take a look, probably it will be next week. |
Six years ago. |
|
Twelve years... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Ruz,
I've updated the code following your recommendations. I think it's now much more polished and DBIx::SearchBuilder-friendly. I did other improvements besides the ones you recommended.
Feel free to comment on the code. I will perform further improvements if required.
Unfortunately, I haven't yet had time to prepare a virtual machine for you to test, and I haven't tested with Microsoft SQL Server yet, which should theoretically work with the changes I performed.
Greetings.