feat: added env read support #127
Open
+179
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces environment configuration support across the SDK and fixes an issue where client tests were being skipped. Description ----------- - Added scans for .env in current and parent directories - Added clean getters for all environment variables - Introduced graceful fallback to system environment variables - Added comprehensive test coverage for the introduced feature Testing ------- From the repo root, run: ``` go test -v ./config/env -run TestEnv ```
Description ----------- - Replaced init with setupClientTest/setupTest functions - Updated test calls with new setup functions Build verified with: ``` make lint && make format ``` Test coverage unchanged
|
@calbera |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces environment configuration support across the SDK and fixes an issue where client tests were being skipped.
Description
Testing the introduced
featClone this pr branch and from the repo root, run:
go test -v ./config/env -run TestEnv