fix(set-env.js): replace fs.globSync with glob.sync #342
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Problem The `set-env.js` script uses `fs.globSync`, which does not exist in the `fs` module, causing a `TypeError` when executed. ### Solution 1. Replaced `fs.globSync` with `glob.sync` from the `glob` module. 2. Added a note that the `glob` module must be installed as a dependency using: ```bash npm install glob Signed-off-by: Himess <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Himess is attempting to deploy a commit to the Berachain Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
set-env.jsscript usesfs.globSync, which does not exist in thefsmodule, causing aTypeErrorwhen executed.Solution
fs.globSyncwithglob.syncfrom theglobmodule.globmodule must be installed as a dependency using: ```bash npm install globChanges Made
-Updated the script to use glob.sync.
-Included the necessary glob module import.
Issue Reference
Resolves #341
Resolves the issue: fs.globSync is not a function in set-env.js script
Test Results
The script was tested after the changes, and it worked as expected without throwing any errors. Below is the output from running the script:
Node.js v20.11.1
Copying files development