feat(gov): Format and display abi inputs on a proposal, show raw switch #316
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
There was a problem hiding this comment.
Well done, it's mostly UI feedbacks
Please let's add the token symbol here, i also wonder what happens if the address was not a token / does not have decimals
Please align this
pls wrap each item of the array with a border
Raw data should still use the same UI wrapper but different content inside (calldata, value, target, function maybe printed as signature )
apps/hub/src/app/governance/[genre]/proposal/[proposalId]/Actions.tsx
Outdated
Show resolved
Hide resolved
apps/hub/src/app/governance/[genre]/proposal/[proposalId]/Actions.tsx
Outdated
Show resolved
Hide resolved
| <FormattedActionLine | ||
| title="Vault Address" | ||
| type="link" | ||
| value={getRewardsVaultUrl(vaultAddress)} |
There was a problem hiding this comment.
the link should be the href, not the shown value
| <img | ||
| src={props.imageUri} | ||
| alt={String(value)} | ||
| className="w-4 h-4 rounded-full" | ||
| /> |
There was a problem hiding this comment.
Please use <TokenIcon /> if it's a token or GaugeIcon if it's a vault. Those components handle not-found images
| {parsedMetadata.data && ( | ||
| <> | ||
| <FormattedActionLine | ||
| key={name} | ||
| title="Name" | ||
| type="string" | ||
| value={name} | ||
| imageUri={logoURI} | ||
| /> | ||
| <FormattedActionLine key={url} title="URL" type="link" value={url} /> | ||
| </> | ||
| )} |
There was a problem hiding this comment.
Let's disable metadata parsing for now, or just let's not render it
Special formatting applied to:
Features: