-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build errors now show correct file names #2242
Conversation
We were running `go build` from inside cmd/beacond so any build errors show a relative path from that directory which is not clickable to view in the editor. Instead we should build from root project directory and give it the path to the package to build.
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2242 +/- ##
=======================================
Coverage 29.54% 29.54%
=======================================
Files 353 353
Lines 16144 16144
Branches 20 20
=======================================
Hits 4769 4769
Misses 11057 11057
Partials 318 318 |
We were running
go build
from inside cmd/beacond so any build errors show a relative path from that directory which is not clickable to view in the editor.Instead we should build from root project directory and give it the path to the package to build.