chore(blockchain) : non optimistic client should not request build optimistically

[nidhi-singh02]

Non optimistic client currently request for build optimistically, fixing it with this changeset.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.70%. Comparing base (36f1a04) to head (a2c93c1).

Files with missing lines	Patch %	Lines
beacon/blockchain/execution_engine.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2240      +/-   ##
==========================================
+ Coverage   30.61%   30.70%   +0.09%     
==========================================
  Files         331      331              
  Lines       15431    15383      -48     
  Branches       20       20              
==========================================
  Hits         4724     4724              
+ Misses      10390    10342      -48     
  Partials      317      317              

Files with missing lines	Coverage Δ
beacon/blockchain/execution_engine.go	0.00% <0.00%> (ø)

[nidhi-singh02]

E2E tests are failing, seems blocks finalisation count is stuck in tests. I am debugging it.

[shotes]

I believe the check for shouldBuildOptimisticPayloads() should be removed. This sendPostBlockFCU() function should always call s.sendNextFCUWithoutAttributes(ctx, blk, lph) whether it is optimistic or not, since all nodes need to notify the execution layer of the fork choice update.

Do note that removing the call to s.sendNextFCUWithAttributes(ctx, st, blk, lph) fixed the issue with triggering optimistic builds - this function should never trigger optimistic builds by sending FCU with attributes.

[nidhi-singh02]

I believe the check for shouldBuildOptimisticPayloads() should be removed. This sendPostBlockFCU() function should always call s.sendNextFCUWithoutAttributes(ctx, blk, lph) whether it is optimistic or not, since all nodes need to notify the execution layer of the fork choice update.

Do note that removing the call to s.sendNextFCUWithAttributes(ctx, st, blk, lph) fixed the issue with triggering optimistic builds - this function should never trigger optimistic builds by sending FCU with attributes.

Makes sense, removing the check worked. Thanks for your valuable pointers @shotes!