Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let the create-validator command retrieve the loaded configuration. #2128

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: let the create-validator command retrieve the loaded configuration. #2128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e88ab1
fix: let the create-validator command retrieve the loaded configuration.
dezzeus Nov 5, 2024
8a0cd92
Merge branch 'main' into fix-create-validator-cmd
abi87 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mod/cli/pkg/commands/deposit/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ import (
"os"

"cosmossdk.io/log"
clicontext "github.com/berachain/beacon-kit/mod/cli/pkg/context"
"github.com/berachain/beacon-kit/mod/cli/pkg/utils/parser"
"github.com/berachain/beacon-kit/mod/consensus-types/pkg/types"
"github.com/berachain/beacon-kit/mod/node-core/pkg/components"
"github.com/berachain/beacon-kit/mod/node-core/pkg/components/signer"
"github.com/berachain/beacon-kit/mod/primitives/pkg/common"
"github.com/berachain/beacon-kit/mod/primitives/pkg/constraints"
"github.com/berachain/beacon-kit/mod/primitives/pkg/crypto"
"github.com/cosmos/cosmos-sdk/client"
"github.com/spf13/cobra"
)

Expand Down Expand Up @@ -164,7 +164,7 @@ func getBLSSigner(

return components.ProvideBlsSigner(
components.BlsSignerInput{
AppOpts: client.GetViperFromCmd(cmd),
AppOpts: clicontext.GetViperFromCmd(cmd),
PrivKey: legacyKey,
},
Comment on lines 166 to 169
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

LGTM: Configuration retrieval fix implemented correctly.

The switch to clicontext.GetViperFromCmd properly fixes the configuration access issue. However, consider adding tests to verify the configuration retrieval behavior.

Would you like me to help create test cases for the configuration retrieval functionality? This would help ensure the fix remains robust against future changes.

)
Expand Down
Loading