-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(block-store): silence pruner logging for not found keys #1891
Conversation
WalkthroughThe recent changes enhance error handling in the Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
===========================================
+ Coverage 21.93% 52.83% +30.89%
===========================================
Files 340 7 -333
Lines 15606 106 -15500
Branches 21 21
===========================================
- Hits 3423 56 -3367
+ Misses 12066 49 -12017
+ Partials 117 1 -116 |
@chuck-bear this will silence "not found" error logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hacky but sure
Summary by CodeRabbit
These changes improve the operational continuity of the application during block pruning.