Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(block-store): silence pruner logging for not found keys #1891

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

calbera
Copy link
Contributor

@calbera calbera commented Aug 12, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling in the pruning process to distinguish between missing blocks and encoding/decoding errors.
    • Enhanced robustness of the pruning method, allowing it to continue processing even when certain errors occur.

These changes improve the operational continuity of the application during block pruning.

Copy link
Contributor

coderabbitai bot commented Aug 12, 2024

Walkthrough

The recent changes enhance error handling in the Prune method of the KVStore class, allowing for more precise identification of errors related to missing blocks versus encoding/decoding issues. By implementing a conditional check, the method can continue processing even when certain errors occur, improving resilience and clarity in the pruning process.

Changes

File Path Change Summary
mod/storage/pkg/block/store.go Improved error handling in the Prune method, allowing the function to distinguish between missing blocks and encoding errors, thus enhancing robustness.

Poem

🐰 In the garden of code, changes bloom bright,
With pruning so smooth, we soar into flight.
Errors once tangled are now clear as day,
We hop through the logic, come what may!
With each little fix, our store's growing strong,
A leap for resilience, a joyful song! 🎶


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 675835e and 5cd07af.

Files selected for processing (1)
  • mod/storage/pkg/block/store.go (2 hunks)

mod/storage/pkg/block/store.go Show resolved Hide resolved
@calbera calbera requested a review from chuck-bear August 12, 2024 21:28
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.83%. Comparing base (80b7351) to head (172bbd0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1891       +/-   ##
===========================================
+ Coverage   21.93%   52.83%   +30.89%     
===========================================
  Files         340        7      -333     
  Lines       15606      106    -15500     
  Branches       21       21               
===========================================
- Hits         3423       56     -3367     
+ Misses      12066       49    -12017     
+ Partials      117        1      -116     

see 333 files with indirect coverage changes

@calbera
Copy link
Contributor Author

calbera commented Aug 12, 2024

@chuck-bear this will silence "not found" error logs

@calbera calbera enabled auto-merge (squash) August 12, 2024 22:29
Copy link
Contributor

@itsdevbear itsdevbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hacky but sure

@calbera calbera merged commit 5813e7b into main Aug 13, 2024
18 checks passed
@calbera calbera deleted the block-store-logger branch August 13, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants