Address review comments

node-core/node/node.go

@@ -69,6 +69,11 @@ func (n *node) Start(
 
 	// Start all the registered services.
 	if err := n.registry.StartAll(gctx); err != nil {
+		// Make sure the services that were successfully started are stopped
+		// before exiting. We assume that it is safe to call Stop on a
+		// service that was never started so we can call StopAll here
+		//#nosec:G703 // ok to ignore this
+		_ = n.registry.StopAll()
 		return err
 	}
 

node-core/services/registry/registry.go

@@ -31,7 +31,8 @@ import (
 type Basic interface {
 	// Start spawns any goroutines required by the service.
 	Start(ctx context.Context) error
-	// Stop stops the service.
+	// Stop stops the service. It should be safe to call
+	// Stop on a service that has not been started
 	Stop() error
 	// Name returns the name of the service.
 	Name() string