Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove human-only chromosome validation #63

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed davidlougheed changed the title [WIP] chore!: remove human-only chromosome validation chore!: remove human-only chromosome validation Nov 6, 2024
@davidlougheed davidlougheed marked this pull request as ready for review November 6, 2024 16:08
Base automatically changed from refact/fixed-mappings to master November 6, 2024 21:22
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this successfully tested with a non-human VCF and reference genome?
I am running into a tabbix issue with a ulaval VCF.
Do we have single sample mice VCFs somewhere?

Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed to ingest a mouse VCF using the GRCm38 reference genome!

@davidlougheed davidlougheed merged commit af17d02 into master Nov 8, 2024
1 check passed
@davidlougheed davidlougheed deleted the chore/support-all-chroms branch November 8, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants