Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact!: fixed mappings for variant indices #62

Merged
merged 17 commits into from
Nov 6, 2024
Merged

refact!: fixed mappings for variant indices #62

merged 17 commits into from
Nov 6, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed davidlougheed marked this pull request as ready for review November 4, 2024 19:33
gsfk
gsfk approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too far behind on go to offer code comments, but vcf ingest seems to be working as expected now.

v-rocheleau
v-rocheleau approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Ran a bunch of tests with Signature VCFs.
I migrated the staging instance of ichange to this PR's build, previous VCFs survived the migration and I was able to ingest new ones after!

@davidlougheed davidlougheed merged commit 9e94ca8 into master Nov 6, 2024
3 checks passed
@davidlougheed davidlougheed deleted the refact/fixed-mappings branch November 6, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-rocheleau v-rocheleau v-rocheleau approved these changes

@gsfk gsfk gsfk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidlougheed @gsfk @v-rocheleau