Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gene autocomplete fix #473

Merged
merged 5 commits into from
Dec 18, 2024
Merged

gene autocomplete fix #473

merged 5 commits into from
Dec 18, 2024

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Dec 11, 2024

Fixes Redmine #2419

  • tabbing while on a pull-down option now selects instead of moving away without selecting
  • removed some N/A helptext when the Gene/Position field is position only

I'll do a separate PR for Redmine #2415.

@gsfk gsfk changed the title gene autocomplete fixes gene autocomplete fix Dec 11, 2024
@gsfk gsfk marked this pull request as ready for review December 11, 2024 20:22
@gsfk gsfk requested a review from davidlougheed December 12, 2024 14:56
davidlougheed
davidlougheed approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsfk
Copy link
Member Author

gsfk commented Dec 18, 2024

oh noes, they be fixing my grammar

@gsfk gsfk merged commit ba025d2 into master Dec 18, 2024
3 checks passed
@davidlougheed davidlougheed deleted the fixes/variants-autocomplete-fixes branch December 18, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsfk @davidlougheed