Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: use hooks in more places + eliminate projects double-fetch #434

Merged
merged 10 commits into from
Sep 11, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed davidlougheed changed the title [WIP] refact: use hooks in more places refact: use hooks in more places Sep 11, 2024
@davidlougheed davidlougheed changed the title refact: use hooks in more places refact: use hooks in more places + eliminate projects double-fetch Sep 11, 2024
@davidlougheed davidlougheed marked this pull request as ready for review September 11, 2024 13:50
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small stuff, looks good

src/components/manager/access/GrantForm.tsx Show resolved Hide resolved
src/modules/metadata/actions.js Show resolved Hide resolved
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidlougheed davidlougheed merged commit 01a9665 into master Sep 11, 2024
3 checks passed
@davidlougheed davidlougheed deleted the refact/hooks-usage branch September 11, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants