refact: rewrite some effect-state updates as functional updates

src/components/SiteHeader.js

@@ -67,8 +67,8 @@ const SiteHeader = () => {
   const [modalVisible, setModalVisible] = useState(false);
 
   const toggleModalVisibility = useCallback(() => {
-    setModalVisible(!modalVisible);
-  }, [modalVisible]);
+    setModalVisible((v) => !v);
+  }, []);
 
   const performSignOut = usePerformSignOut();
 

src/components/discovery/DiscoveryQueryBuilder.js

@@ -121,8 +121,8 @@ const DiscoveryQueryBuilder = ({ activeDataset, dataTypeForms, requiredDataTypes
   );
 
   const handleHelpAndSchemasToggle = useCallback(() => {
-    setSchemasModalShown(!schemasModalShown);
-  }, [schemasModalShown]);
+    setSchemasModalShown((s) => !s);
+  }, []);
 
   const handleSetFormRef = useCallback(
     (dataType, form) => {

src/components/explorer/IndividualTracks.js

@@ -270,15 +270,15 @@ const IndividualTracks = ({ individual }) => {
       if (!igvBrowserRef.current) return;
 
       const wasViewing = track.viewInIgv;
-      setAllTracks(allTracks.map((t) => (t.filename === track.filename ? { ...track, viewInIgv: !wasViewing } : t)));
+      setAllTracks((at) => at.map((t) => (t.filename === track.filename ? { ...track, viewInIgv: !wasViewing } : t)));
 
       if (wasViewing) {
         igvBrowserRef.current.removeTrackByName(track.filename);
       } else {
         igvBrowserRef.current.loadTrack(buildIgvTrack(igvUrls, track)).catch(console.error);
       }
     },
-    [allTracks, igvUrls],
+    [igvUrls],
   );
 
   const storeIgvPosition = useCallback(

src/components/manager/drs/ManagerDRSContent.js

@@ -240,8 +240,8 @@ const ManagerDRSContent = () => {
   }, [performSearch, searchValue]);
 
   useEffect(() => {
-    setSelectedRowKeys(selectedRowKeys.filter((k) => k in objectsByID));
-  }, [selectedRowKeys, objectsByID]);
+    setSelectedRowKeys((s) => s.filter((k) => k in objectsByID));
+  }, [objectsByID]);
 
   const onDeleteSelected = useCallback(() => {
     Modal.confirm({

src/components/manager/projects/Project.js

@@ -61,13 +61,13 @@ const Project = ({
 
   useEffect(() => {
     if (value) {
-      setProjectState({
-        ...projectState,
+      setProjectState((ps) => ({
+        ...ps,
         ...value,
         data_use: simpleDeepCopy(value.data_use || INITIAL_DATA_USE_VALUE),
-      });
+      }));
     }
-  }, [value, projectState]);
+  }, [value]);
 
   const handleSave = useCallback(() => {
     const form = editingForm.current;