Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: check for hook misusage in lint step [redo] #417

Merged
merged 13 commits into from
Aug 19, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

Base automatically changed from refact/display-ts to master August 14, 2024 13:46
@davidlougheed davidlougheed changed the title [WIP] lint: check for hook misusage in lint step [redo] lint: check for hook misusage in lint step [redo] Aug 14, 2024
@davidlougheed davidlougheed marked this pull request as ready for review August 14, 2024 17:08
lint: enforce "import type" for typescript
Copy link
Contributor

@SanjeevLakhwani SanjeevLakhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, appreciate the effort!

Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only hurdle for me here is that DiscoverySearchForm.js appears to be broken in current master, so hard to test changes.

@davidlougheed davidlougheed merged commit 50ef0e6 into master Aug 19, 2024
3 checks passed
@davidlougheed davidlougheed deleted the refact/hook-lint-fixes branch August 19, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants