Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dataset data-types count loading #413

Merged
merged 5 commits into from
Jul 11, 2024
Merged

fix: dataset data-types count loading #413

merged 5 commits into from
Jul 11, 2024

Conversation

v-rocheleau
Copy link
Contributor

Small fix for dataset data-types count stuck on loading.
The dataset's data-types were not properly accessed by ID.

noctillion
noctillion approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@noctillion noctillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gsfk
gsfk approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The actual rendering of this value is a bit weird, but that's an issue elsewhere: it flashes weirdly for me in both Chrome and Firefox:

flashy_three

.. but this can be handled elsewhere

davidlougheed
davidlougheed requested changes Jul 9, 2024
View reviewed changes
src/components/datasets/DatasetOverview.js Outdated Show resolved Hide resolved
src/components/datasets/DatasetOverview.js Outdated Show resolved Hide resolved
src/modules/datasets/hooks.js Outdated Show resolved Hide resolved
davidlougheed
davidlougheed requested changes Jul 9, 2024
View reviewed changes
src/modules/datasets/hooks.js Outdated Show resolved Hide resolved
davidlougheed
davidlougheed approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, but I think we could do more with the isFetching inside useDatasetDataTypesByID to make loading logic more complete for the data type count statistic.

src/components/datasets/DatasetOverview.js Show resolved Hide resolved
davidlougheed
davidlougheed approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice!

@v-rocheleau v-rocheleau merged commit 69907e6 into master Jul 11, 2024
3 checks passed
@v-rocheleau v-rocheleau deleted the fix/data-type-counts branch July 11, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

@gsfk gsfk gsfk approved these changes

@noctillion noctillion noctillion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-rocheleau @davidlougheed @gsfk @noctillion