Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more UI-displayable file types for drop box + experiment results #307

Merged
merged 28 commits into from
Oct 24, 2023
Merged

feat: more UI-displayable file types for drop box + experiment results #307

merged 28 commits into from
Oct 24, 2023

Conversation

davidlougheed
Copy link
Member

@davidlougheed davidlougheed commented Oct 4, 2023 •
edited
Loading

the following file types should be now viewable in drop box and in experiment results:

  • CSV
  • TSV
  • images (JPEG, PNG, GIF, etc.)
  • markdown
  • audio files (MP3, M4A)
  • video files (MP4)
  • DOCX
  • XLS/XLSX

@davidlougheed davidlougheed changed the title feat(manager): more drop box displayable file types + factored-out file display component feat(manager): more UI-displayable file types for drop box + experiment results Oct 4, 2023
@davidlougheed davidlougheed changed the title feat(manager): more UI-displayable file types for drop box + experiment results feat: more UI-displayable file types for drop box + experiment results Oct 4, 2023
@davidlougheed
lint
015f246
@davidlougheed
lint: rm console log
37cd3ba
@davidlougheed
chore: csv-display memoization
d005bdc
@davidlougheed
fix: bad language highlighter selection in file display
4da41cf
@davidlougheed
style(manager): widen drop box modal width
734f427
@davidlougheed
add todo
0e63dca
@davidlougheed
feat(explorer): add view file ability for experiment results
08c0b12
@davidlougheed
Merge remote-tracking branch 'origin/master' into feat/exp-res-display
9e3679c
@davidlougheed
perf(manager): upmount modal child components on close to avoid mem l…
b8e2567 
…eaks
@davidlougheed
lint: rm debug log
33f5934
@davidlougheed
feat: add audio and video support to file displayer
6410ba2
@davidlougheed
chore: update dep
eaed37e
@davidlougheed
style: paginate csv display
cb76b41
@davidlougheed
feat: add xls/xlsx file display capabilities
c5f622c
@davidlougheed
fix: case sensitivity with file extensions
f8b1795
@davidlougheed
chore: add webm as viewable file
0e033f8
@davidlougheed
lint
ae8654e
@davidlougheed
feat: add markdown file display
433eab5
@davidlougheed
lint
f457663
@davidlougheed
Merge remote-tracking branch 'origin/master' into feat/exp-res-display
bceb587
@davidlougheed
feat: add docx rendering to file display
0b325ea
@davidlougheed
chore: improved loading behaviour/styling for file display
2779098
@davidlougheed davidlougheed requested a review from gsfk October 24, 2023 14:41
gsfk
gsfk approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tried a bunch of file types with no real issues.

The fixed-width modal makes a few files uglier than they could be, but I don't think that matters.

src/components/display/FileDisplay.js Outdated Show resolved Hide resolved
@davidlougheed davidlougheed merged commit 3965610 into master Oct 24, 2023
@davidlougheed davidlougheed deleted the feat/exp-res-display branch October 24, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsfk gsfk gsfk approved these changes

@noctillion noctillion Awaiting requested review from noctillion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlougheed @gsfk