Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: delete variants on project/dataset deletion; load data types/workflows from service-registry; rm hardcoding artifacts #287

Merged
merged 7 commits into from
Sep 1, 2023

Conversation

v-rocheleau
Copy link
Contributor

@v-rocheleau v-rocheleau commented Aug 31, 2023

refact!: load data types + workflows from new service registry (1.2.0+) & clean up dependents

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my opinion data types should be cleared before deletion, not after success - this way, if a clear fails, we still have the dataset definition and so we can try again. otherwise, we need to go into Elasticsearch to clear the variants (or Katsu Postgres for others).

Also, it would be better if this iterated through all data types and created promises to clear them in parallel - in the future datasets might not be part of Katsu, and so Katsu will need to know about dataset deletion.

@davidlougheed davidlougheed changed the title perf: delete variants on project/dataset deletion feat: delete variants on project/dataset deletion Sep 1, 2023
@davidlougheed davidlougheed changed the title feat: delete variants on project/dataset deletion feat!: delete variants on project/dataset deletion Sep 1, 2023
@davidlougheed davidlougheed changed the title feat!: delete variants on project/dataset deletion feat!: delete variants on project/dataset deletion; load data types/workflows from SR Sep 1, 2023
@davidlougheed davidlougheed changed the title feat!: delete variants on project/dataset deletion; load data types/workflows from SR feat!: delete variants on project/dataset deletion; load data types/workflows from service-registry Sep 1, 2023
@davidlougheed davidlougheed changed the title feat!: delete variants on project/dataset deletion; load data types/workflows from service-registry feat!: delete variants on project/dataset deletion; load data types/workflows from service-registry; rm hardcoding artifacts Sep 1, 2023
@davidlougheed davidlougheed merged commit d670e39 into master Sep 1, 2023
3 checks passed
@davidlougheed davidlougheed deleted the fix/dataset-delete branch September 1, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants