Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15] feat: implement new workflow system #282

Merged
merged 31 commits into from
Nov 21, 2023
Merged

[15] feat: implement new workflow system #282

merged 31 commits into from
Nov 21, 2023

Conversation

davidlougheed
Copy link
Member

No description provided.

Base automatically changed from features/table-removal to master August 30, 2023 20:26
@davidlougheed davidlougheed changed the base branch from master to chore/new-authz October 24, 2023 18:04
@davidlougheed davidlougheed changed the title [WIP] [14] feat: add dataset workflow input capability [WIP] [15] feat: add dataset workflow input capability Nov 2, 2023
Base automatically changed from chore/new-authz to master November 13, 2023 19:28
@davidlougheed davidlougheed marked this pull request as draft November 13, 2023 19:30
@davidlougheed davidlougheed changed the title [WIP] [15] feat: add dataset workflow input capability [WIP] [15] feat: implement new workflow system Nov 14, 2023
@davidlougheed davidlougheed marked this pull request as ready for review November 14, 2023 17:44
@davidlougheed davidlougheed changed the title [WIP] [15] feat: implement new workflow system [15] feat: implement new workflow system Nov 14, 2023
@davidlougheed davidlougheed changed the title [15] feat: implement new workflow system [WIP] [15] feat: implement new workflow system Nov 14, 2023
@davidlougheed davidlougheed marked this pull request as draft November 14, 2023 17:44
@davidlougheed davidlougheed changed the title [WIP] [15] feat: implement new workflow system [15] feat: implement new workflow system Nov 14, 2023
@davidlougheed davidlougheed changed the title [15] feat: implement new workflow system feat: implement new workflow system Nov 14, 2023
@davidlougheed davidlougheed marked this pull request as ready for review November 14, 2023 20:55
v-rocheleau
v-rocheleau requested changes Nov 21, 2023
View reviewed changes
src/components/manager/ManagerDropBoxContent.js Outdated Show resolved Hide resolved
src/components/manager/RunSetupInputForm.js Show resolved Hide resolved
src/components/manager/WorkflowListItem.js Outdated Show resolved Hide resolved
src/components/manager/WorkflowSelection.js Outdated Show resolved Hide resolved
src/modules/wes/actions.js Outdated Show resolved Hide resolved
@davidlougheed davidlougheed changed the title feat: implement new workflow system [15] feat: implement new workflow system Nov 21, 2023
v-rocheleau
v-rocheleau requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there is only an error with the workflow runs call

src/modules/wes/actions.js Show resolved Hide resolved
v-rocheleau
v-rocheleau approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidlougheed davidlougheed merged commit 4282ac5 into master Nov 21, 2023
3 checks passed
@davidlougheed davidlougheed deleted the feat/dataset-workflow-input branch November 21, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-rocheleau v-rocheleau v-rocheleau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlougheed @v-rocheleau