Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle undefined file params in workflow run last content component #275

Merged
merged 2 commits into from
Aug 8, 2023
Merged

fix: handle undefined file params in workflow run last content component #275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e48bf1
refact: invert if logic for lest indenting
davidlougheed Aug 8, 2023
afc4d7f
fix: handle undefined file params in workflow run last content component
davidlougheed Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 35 additions & 29 deletions src/components/manager/runs/RunLastContent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,38 +112,44 @@ const processIngestions = (data, currentTables) => {
const currentTableIds = new Set((currentTables || []).map((table) => table.table_id));

const ingestionsByDataType = data.reduce((ingestions, run) => {
if (run.state === "COMPLETE") {
const dataType = run.details.request.tags.workflow_metadata.data_type;
const tableId = run.details.request.tags.table_id;
if (run.state !== "COMPLETE") {
return ingestions;
}

if (tableId === undefined || !currentTableIds.has(tableId)) {
return ingestions;
}
const fileNameKey = getFileInputsFromWorkflowMetadata(run.details.request.tags.workflow_metadata);
const filePaths = fileNameKey.flatMap(key =>
Array.isArray(run.details.request.workflow_params[key])
? run.details.request.workflow_params[key]
: [run.details.request.workflow_params[key]],
);
const fileNames = Array.isArray(filePaths)
? filePaths.map(fileNameFromPath)
: [fileNameFromPath(filePaths)];

const date = Date.parse(run.details.run_log.end_time);

const currentIngestion = { date, dataType, tableId, fileNames };
const dataTypeAndTableId = buildKeyFromRecord(currentIngestion);

if (ingestions[dataTypeAndTableId]) {
const existingDate = ingestions[dataTypeAndTableId].date;
if (date > existingDate) {
ingestions[dataTypeAndTableId].date = date;
}
ingestions[dataTypeAndTableId].fileNames.push(...fileNames);
} else {
ingestions[dataTypeAndTableId] = currentIngestion;
const { workflow_metadata: workflowMetadata, table_id: tableId } = run.details.request.tags;

if (tableId === undefined || !currentTableIds.has(tableId)) {
return ingestions;
}

const fileNames =
getFileInputsFromWorkflowMetadata(run.details.request.tags.workflow_metadata)
.flatMap(key => {
const paramValue = run.details.request.workflow_params[key];
if (!paramValue) {
// Key isn't in workflow params or is null
// - possibly optional field or something else going wrong
return [];
}
return Array.isArray(paramValue) ? paramValue : [paramValue];
})
.map(fileNameFromPath);

const date = Date.parse(run.details.run_log.end_time);

const currentIngestion = { date, dataType: workflowMetadata.data_type, tableId, fileNames };
const dataTypeAndTableId = buildKeyFromRecord(currentIngestion);

if (ingestions[dataTypeAndTableId]) {
const existingDate = ingestions[dataTypeAndTableId].date;
if (date > existingDate) {
ingestions[dataTypeAndTableId].date = date;
}
ingestions[dataTypeAndTableId].fileNames.push(...fileNames);
} else {
ingestions[dataTypeAndTableId] = currentIngestion;
}

return ingestions;
}, {});

Expand Down