feat: dataset-level disabling of data type querying by count #272
Conversation
davidlougheed
changed the title
| ...state, | ||
| itemsByDatasetID: { | ||
| ...state.itemsByDatasetID, | ||
| [datasetID]: [...existingItems, ...data], |
There was a problem hiding this comment.
this should replace, not combine I think - otherwise this could append forever
There was a problem hiding this comment.
also, this has a different schema for itemsByDatasetID.datasetId items than the below redux error handling - which one is right?
There was a problem hiding this comment.
as we discussed before, this action is not idempotent - meaning it doesn't give the same result if it is called again. a way to fix this would be to further break this down by either data type ID (nested object) and then optionally also create a flattened version but from this object so there arent duplicate values.
dataTypes in DataTypeExplorationModal
filteredDataTypes for clarity
dataset for variant
| ...state, | ||
| itemsByDatasetID: { | ||
| ...state.itemsByDatasetID, | ||
| [datasetID]: [...existingItems, ...data], |
There was a problem hiding this comment.
as we discussed before, this action is not idempotent - meaning it doesn't give the same result if it is called again. a way to fix this would be to further break this down by either data type ID (nested object) and then optionally also create a flattened version but from this object so there arent duplicate values.
|
Replaced by Features/table-removal-dataset-level-disable #283. Closed by refactoring for V13. |
This PR introduces the handle of the data type-disabling by dataset.
Related to Feature #1675