refact: rewrite some effect-state updates as functional updates

bento-platform · Aug 21, 2024 · c641f31 · c641f31
1 parent 01507ef
commit c641f31
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/components/manager/drs/ManagerDRSContent.js b/src/components/manager/drs/ManagerDRSContent.js
@@ -240,8 +240,8 @@ const ManagerDRSContent = () => {
   }, [performSearch, searchValue]);
 
   useEffect(() => {
-    setSelectedRowKeys(selectedRowKeys.filter((k) => k in objectsByID));
-  }, [selectedRowKeys, objectsByID]);
+    setSelectedRowKeys((s) => s.filter((k) => k in objectsByID));
+  }, [objectsByID]);
 
   const onDeleteSelected = useCallback(() => {
     Modal.confirm({

diff --git a/src/components/manager/projects/Project.js b/src/components/manager/projects/Project.js
@@ -61,13 +61,13 @@ const Project = ({
 
   useEffect(() => {
     if (value) {
-      setProjectState({
-        ...projectState,
+      setProjectState((ps) => ({
+        ...ps,
         ...value,
         data_use: simpleDeepCopy(value.data_use || INITIAL_DATA_USE_VALUE),
-      });
+      }));
     }
-  }, [value, projectState]);
+  }, [value]);
 
   const handleSave = useCallback(() => {
     const form = editingForm.current;