variants dataset summary data in redux store

bento-platform · Aug 23, 2023 · b5b6c48 · b5b6c48
1 parent 2b91620
commit b5b6c48
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/src/modules/datasets/actions.js b/src/modules/datasets/actions.js
@@ -21,7 +21,8 @@ const fetchDatasetSummary = networkAction((serviceInfo, datasetID) => ({
     url: `${serviceInfo.url}/datasets/${datasetID}/summary`,
 }));
 
-export const fetchDatasetSummaryIfPossible = (datasetID) => (dispatch, getState) => {
+export const fetchDatasetSummaryIfPossible = (datasetID) => async (dispatch, getState) => {
     if (getState().datasetSummaries.isFetching) return;
-    return dispatch(fetchDatasetSummary(getState().services.itemsByArtifact.metadata, datasetID));
+    await dispatch(fetchDatasetSummary(getState().services.itemsByArtifact.metadata, datasetID));
+    await dispatch(fetchDatasetSummary(getState().services.itemsByArtifact.gohan, datasetID));
 };
diff --git a/src/modules/datasets/reducers.js b/src/modules/datasets/reducers.js
@@ -55,19 +55,32 @@ export const datasetSummaries = (
     action,
 ) => {
     switch (action.type) {
-        case FETCH_DATASET_SUMMARY.REQUEST:
+        case FETCH_DATASET_SUMMARY.REQUEST:{
+            const {datasetID} = action;
             return {
                 ...state,
                 isFetching: true,
+                itemsById: {
+                    ...state.itemsById,
+                    [datasetID]: {
+                        ...(state.itemsById[datasetID] ?? {}),
+                    },
+                },
             };
-        case FETCH_DATASET_SUMMARY.RECEIVE:
+        }
+        case FETCH_DATASET_SUMMARY.RECEIVE:{
+            const {datasetID} = action;
             return {
                 ...state,
                 itemsById: {
                     ...state.itemsById,
-                    [action.datasetID]: action.data,
+                    [datasetID]: {
+                        ...state.itemsById[datasetID],
+                        ...action.data,
+                    },
                 },
             };
+        }
         case FETCH_DATASET_SUMMARY.FINISH:
         case FETCH_DATASET_SUMMARY.ERROR:
             return {