Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address confusing UX for network chromosome/assembly #233

Merged
merged 2 commits into from
Nov 26, 2024
Merged

chore: address confusing UX for network chromosome/assembly #233

merged 2 commits into from
Nov 26, 2024

Conversation

davidlougheed
Copy link
Member

now chromosome won't be disabled/"select an assembly"'d for beacon network, since there isn't a contig dropdown

@davidlougheed davidlougheed requested a review from gsfk November 26, 2024 19:55
gsfk
gsfk reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the layout of the form, it's probably expected I fill in "chromosome" first and "assembly ID" second, but when I choose an assembly it blanks my chromosome choice.....

@davidlougheed
Copy link
Member Author

forgot about that, thanks for the catch.

@davidlougheed davidlougheed requested a review from gsfk November 26, 2024 20:16
@davidlougheed davidlougheed merged commit 09e460e into main Nov 26, 2024
2 checks passed
@davidlougheed davidlougheed deleted the chore/network-chrom-ux branch November 26, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsfk gsfk gsfk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlougheed @gsfk