Dataset Catalog #225
Dataset Catalog #225
Conversation
There was a problem hiding this comment.
Carousel autoplay is a bit.... I don't know, aggresive? I think we typically avoid animations, Also: https://shouldiuseacarousel.com/
For projects with a single dataset, I still get left and right arrows, is this intentional?
# Conflicts: # src/public/locales/en/default_translation_en.json # src/public/locales/fr/default_translation_fr.json
src/js/components/Provenance/Catalogue/CatalogueCarouselDataset.tsx
Outdated
Show resolved
Hide resolved
src/js/components/Provenance/Catalogue/CatalogueCarouselDataset.tsx
Outdated
Show resolved
Hide resolved
src/js/components/Provenance/Catalogue/CatalogueCarouselDataset.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| export const isoDateToString = (d: string, lang?: string) => { | ||
| const dateLang = lang === 'fr' ? 'fr-CA' : 'en-US'; | ||
| return new Date(d).toLocaleString(dateLang, { |
There was a problem hiding this comment.
why not use i18n.language (or in this case the lang argument) directly here?
There was a problem hiding this comment.
I gets accessed before i18n is initialized causing issues.
There was a problem hiding this comment.
but can it be passed into the function elsewhere, thus mitigating the "if french else assume english" extra logic?
There was a problem hiding this comment.
I can create a utility function for it to separate logic., but I think such logic also exists on the initial render of the website (except there is an extra log statement for saying unsupported language).
|
|
||
| const MAX_KEYWORD_CHARACTERS = 50; | ||
|
|
||
| const CatalogueCard = ({ project }: { project: Project }) => { |
There was a problem hiding this comment.
I think for consistency this should be called Project. we can then later split it into multiple view modes, like with Dataset.
There was a problem hiding this comment.
I would rather change, Dataset to CatalogDataset as Dataset/Project by itself can mean multiple things in public context by conflicting with overview. I do understand that it is in a folder but the naming does reduce the readability.
There was a problem hiding this comment.
catalogdataset to me doesn't make sense, as the dataset isn't just used in the catalog
There was a problem hiding this comment.
I mean it in the form that a "Dataset" could mean multiple things while at least prefixing catalog tells the purpose. If you think otherwise still, lmk, I shall change it.
# Conflicts: # src/js/components/Overview/PublicOverview.tsx # src/public/locales/en/default_translation_en.json # src/public/locales/fr/default_translation_fr.json
Added a dataset catalog which is displayed in the overview tab when no project is selected