refact: rewrite fetching based on checks+hooks #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hoping this fixes https://redmine.c3g-app.sd4h.ca/issues/2385 @v-rocheleau |
…ed-fetches # Conflicts: # src/js/components/Overview/ChartCard.tsx # src/js/components/Overview/OverviewDisplayData.tsx
gsfk
approved these changes
Nov 7, 2024
…ed-fetches # Conflicts: # src/js/components/Overview/PublicOverview.tsx # src/js/features/content/content.store.ts
…ed-fetches # Conflicts: # src/js/features/config/config.store.ts
…ed-fetches # Conflicts: # src/js/components/BentoAppRouter.tsx # src/js/features/metadata/metadata.store.ts
v-rocheleau
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Fails build with one error:
bentov2-public | ERROR in /bento-public/src/js/components/Beacon/BeaconSearchResults.tsx
bentov2-public | ./src/js/components/Beacon/BeaconSearchResults.tsx 5:10-33
bentov2-public | [tsl] ERROR in /bento-public/src/js/components/Beacon/BeaconSearchResults.tsx(5,11)
bentov2-public | TS2339: Property 'isFetchingQueryResponse' does not exist on type 'BeaconState'.
bentov2-public | ts-loader-default_e3b0c44298fc1c14
bentov2-public | @ ./src/js/components/Beacon/BeaconQueryUi.tsx 7:0-56 13:161-180
bentov2-public | @ ./src/js/components/BentoAppRouter.tsx 18:0-51 84:453-466 84:1035-1048 84:1630-1643
bentov2-public | @ ./src/js/index.tsx 15:0-57 30:265-279
|
we're postponing this one til 18 or onwards since Sanjeeve disagrees with the lazy-loading approach somewhat here @v-rocheleau - i'll convert back to a draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap various state fetches in hooks and manage dispatches on an as-needed basis instead of all piled in the router component.
Should also fix some issues with glitched loading of dashboard with a project/dataset selected on load.