Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: single translation function with fallback + missing i18n #211

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed davidlougheed requested review from gsfk, SanjeevLakhwani and v-rocheleau and removed request for v-rocheleau October 25, 2024 20:21
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

I had to look closely at the translations, and that brought up lots of issues, but I don't think any of them are specific to this branch. I'll write a ticket for that instead.

Copy link
Contributor

@SanjeevLakhwani SanjeevLakhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidlougheed davidlougheed merged commit 375dc62 into feat/overview/dataset-card Nov 5, 2024
2 checks passed
@davidlougheed davidlougheed deleted the i18n/fallback branch November 5, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants