Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: combine beacon and network double-slices #206

Merged
merged 17 commits into from
Oct 22, 2024
Merged

refact: combine beacon and network double-slices #206

merged 17 commits into from
Oct 22, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed
style: tweak styling for about HTML content
a692d8c
@davidlougheed
style: stylesheet comments
be87750
@davidlougheed
fix: use custom entrypoint again
826bfd9
@davidlougheed
style: apply about margin fixup to all header types
0a1e8eb
@davidlougheed
lint: fix CSS comment
f10ab88
@davidlougheed
Merge pull request #200 from bento-platform/fix/entrypoint
70b044b 
fix: use custom entrypoint again
@davidlougheed
style: no top margin for any first element in about box
4bd366a
@davidlougheed
Merge pull request #199 from bento-platform/style/about-content
312347f 
style: tweak styling for about HTML content
@davidlougheed
feat: help text for Bento concepts in counts display
4bdf968 
also refactors translations for entities to be more structured.
@davidlougheed
refact: combine beacon and network double-slices
d9c1080
@davidlougheed
refact: beacon network dispatch conditions + URL
ca43785
@davidlougheed
refact(beacon): move apiErrorMessage to BeaconQueryUi param
172d18e
@davidlougheed
lint
9118bb7
@davidlougheed davidlougheed requested a review from gsfk October 21, 2024 19:56
@davidlougheed
chore: clean up counts translation/help stuff
77d8a6d
@davidlougheed
Merge pull request #205 from bento-platform/feat/bento-concepts-help
7e4d9d2 
feat: help text for Bento concepts in counts display
@davidlougheed
Merge remote-tracking branch 'origin/main' into refact/beacon-slices
3937c23 
# Conflicts:
#	src/js/components/Beacon/BeaconQueryUi.tsx
#	src/js/components/Search/SearchResultsPane.tsx
#	src/styles.css
@davidlougheed
lint(beacon): query UI input order
3b318c2
gsfk
gsfk approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice... seems to work well, thanks for the hook!

Only thing I thought was overkill was the extra boilerplate in errorMsgOrDefault but I see I already let that slip by.

@davidlougheed davidlougheed merged commit b8e8f18 into features/beacon-network Oct 22, 2024
2 checks passed
@davidlougheed davidlougheed deleted the refact/beacon-slices branch October 22, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsfk gsfk gsfk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlougheed @gsfk