Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: beacon network styling #201

Merged
merged 7 commits into from
Oct 10, 2024
Merged

style: beacon network styling #201

merged 7 commits into from
Oct 10, 2024

Conversation

davidlougheed
Copy link
Member

@davidlougheed davidlougheed commented Oct 9, 2024 •
edited
Loading

  • Non-fixed-width network nodes
  • Use Ant column/row system for nodes
  • Removes some unnecessary CSS
  • Fixes up titled search results display
  • Adds logo alt text

@davidlougheed davidlougheed changed the title [WIP] style: beacon network styling style: beacon network styling Oct 10, 2024
@davidlougheed davidlougheed marked this pull request as ready for review October 10, 2024 16:54
@davidlougheed davidlougheed requested a review from gsfk October 10, 2024 16:54
gsfk
gsfk reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Only weird behaviour I could produce is when screen width is very narrow and one beacon name is long. But this puts us into telephone screen dimensions where there are existing issues already.

Screenshot from 2024-10-10 13-25-46

@davidlougheed davidlougheed requested a review from gsfk October 10, 2024 17:54
@davidlougheed davidlougheed merged commit 2bb70b6 into features/beacon-network Oct 10, 2024
2 checks passed
@davidlougheed davidlougheed deleted the style/beacon-network branch October 10, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsfk gsfk gsfk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlougheed @gsfk