Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI selector for project/dataset #171

Merged
merged 29 commits into from
Aug 26, 2024
Merged

Conversation

SanjeevLakhwani
Copy link
Contributor

@SanjeevLakhwani SanjeevLakhwani commented Jul 29, 2024

Follows from #161

  • improved over the existing redux over the metadata, reducing more stateful property
  • Found a bug with /callback in index.js, it was never being triggered as a specific route as it was being accessed before by :lang param
  • provided routing for project/dataset navigation by the format of /p/projecId/d/datasetId, rendered to the level needed
  • modified the ui to select project/dataset
  • improvided on app structure by having separation of concerns with components and using Outlets and Loaders

@SanjeevLakhwani SanjeevLakhwani self-assigned this Aug 5, 2024
@SanjeevLakhwani SanjeevLakhwani requested review from gsfk and removed request for v-rocheleau August 5, 2024 17:25
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix merge conflicts.

src/js/components/ChooseProjectModal.tsx Outdated Show resolved Hide resolved
src/js/components/ChooseProjectModal.tsx Outdated Show resolved Hide resolved
src/js/components/ChooseProjectModal.tsx Show resolved Hide resolved
@davidlougheed davidlougheed changed the title Features/new discovery feat: UI selector for project/dataset Aug 7, 2024
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

still many rendering glitches here:

  • unneeded margin above project title
  • project title and datasets subheading should not be the same heading level
  • button margin for "clear selection"
  • hover background for dataset goes outside of border radius bounds
  • text in header isn't aligned with icon vertically
  • I think the node heading should be a bit bigger, and then so should this selector heading in the header

src/styles.css Show resolved Hide resolved
src/styles.css Show resolved Hide resolved
@davidlougheed
Copy link
Member

image
i also get this when I load – no routes match /

@SanjeevLakhwani SanjeevLakhwani force-pushed the features/new-discovery branch from 9fae22b to 922b637 Compare August 8, 2024 17:46
@davidlougheed
Copy link
Member

image

src/js/components/ChooseProjectModal.tsx Outdated Show resolved Hide resolved
src/js/components/SiteHeader.tsx Outdated Show resolved Hide resolved
src/js/components/SiteHeader.tsx Outdated Show resolved Hide resolved
src/js/features/metadata/metadata.store.ts Outdated Show resolved Hide resolved
src/js/index.tsx Outdated Show resolved Hide resolved
src/js/index.tsx Outdated Show resolved Hide resolved
src/js/components/Util/LanguageHandler.tsx Outdated Show resolved Hide resolved
src/js/components/SiteHeader.tsx Outdated Show resolved Hide resolved
src/js/components/SiteHeader.tsx Show resolved Hide resolved
src/js/components/SiteHeader.tsx Show resolved Hide resolved
src/js/types/metadata.ts Outdated Show resolved Hide resolved
src/js/types/metadata.ts Outdated Show resolved Hide resolved
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SanjeevLakhwani SanjeevLakhwani merged commit 289ee8d into main Aug 26, 2024
2 checks passed
@davidlougheed davidlougheed deleted the features/new-discovery branch August 26, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants