-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UI selector for project/dataset #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still many rendering glitches here:
- unneeded margin above project title
- project title and datasets subheading should not be the same heading level
- button margin for "clear selection"
- hover background for dataset goes outside of border radius bounds
- text in header isn't aligned with icon vertically
- I think the node heading should be a bit bigger, and then so should this selector heading in the header
9fae22b
to
922b637
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Follows from #161
/callback
in index.js, it was never being triggered as a specific route as it was being accessed before by :lang param