Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Beacon network UI #165

Merged
merged 105 commits into from
Oct 22, 2024
Merged

feat: Beacon network UI #165

merged 105 commits into from
Oct 22, 2024

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Jun 11, 2024 •
edited
Loading

First pass at a UI for Bento beacon network. Requires Bento 17 and bento_beacon pr #93.

Features:

  • aggregated statistics for each query
  • aggregation is done here rather than in the backend, results are updated in real time rather than having to wait for all beacons to respond.
  • individual results are shows for each beacon in the network even if there are zero results.
  • refactor some beacon components to handle either network or single beacon queries.

gsfk added 30 commits May 15, 2024 11:37
@gsfk
factor out beacon tooltips
cdfce1e
@gsfk
add beacon network tab
893925a
@gsfk
temp network types
e597806
@gsfk
redux for beacon network config
a18382b
@gsfk
updates to beacon types
331fcc7
@gsfk
dead code
6010861
@gsfk
second pass at network config redux
929dabc
@gsfk
redux for single network beacon
3a0f373
@gsfk
first pass at beacon network query redux
e329bfd
@gsfk
beacon network redux
81de8e4
@gsfk
beacon typing additions
d95ee5f
@gsfk
first pass of card for network beacon
f0a7a92
@gsfk
beacon org
1a7a63b
@gsfk
add network to tabbed dashboard
7f45677
@gsfk
add beacon network redux to store
abafc28
@gsfk
first pass at common beacon / beacon network form UI
69d9c27
@gsfk
network beacon redux
c8d64f0
@gsfk
reducer for network overview
c729ec9
@gsfk
toggle for network query filters
9e13ecb
@gsfk
first pass at beacon common filters components
dd62264
@gsfk
compute overview in client
36bd7a3
@gsfk
network search results
6ebe900
@gsfk
add content to header of network search results
a1340a6
@gsfk
add skeleton to beacon counts
aa78fc0
@gsfk
network types
bb50d87
@gsfk
temp fake stuff for network UI
37ae4c3
@gsfk
eslint does not like obj.hasOwnProperty()
3754560
@gsfk
first pass at network beacon details
74be53c
@gsfk
misc network fixes and cleanup
f6abac7
@gsfk
fix temp network root url
508d14f
@davidlougheed davidlougheed changed the title Features/beacon network feat: Beacon network UI Oct 9, 2024
@davidlougheed
style: ellipsis-overflow beacon network node org name
6314139
@davidlougheed
style: use antd row/col for beacon network nodes
e61306f
@davidlougheed
lint: rm commented-out code
b9df821
@davidlougheed
lint: rm more commented-out code
aa17b3d
@davidlougheed
style: fix responsiveness issues for network
7303a33
@davidlougheed
lint
64c87b5
@davidlougheed
Merge pull request #201 from bento-platform/style/beacon-network
2bb70b6 
style: beacon network styling
@davidlougheed
refact: useBeaconNetwork hook + some translation
41dcf36
@davidlougheed
fix: revert bad refactor in NetworkSearchResults
fe8916c
@davidlougheed
refact(beacon): memoization in query form UI
715b128
@davidlougheed
style: fix search result statistic padding when disabled
4c3a177
@davidlougheed
Merge pull request #202 from bento-platform/chore/network-tweaks
303dc42 
refact: useBeaconNetwork hook + some translation
@davidlougheed
refact: factor out common types for discovery results + new types
a3157cf 
also some misc. beacon network tweaks
@davidlougheed
refact(beacon-network): destructure beacon results
8c4af73
@davidlougheed
fix: show zero individuals as dashes in network node counts
c63629a
@davidlougheed
chore: note mode for SearchResultsCountsProps
e458bf5
@davidlougheed
fix: proper beacon network counts behaviour
f321932
@davidlougheed
Merge pull request #204 from bento-platform/refact/beacon-network-redux
0a0fbdc 
refact: factor out common types for discovery results + new types
@davidlougheed
refact: combine beacon and network double-slices
d9c1080
@davidlougheed
refact: beacon network dispatch conditions + URL
ca43785
@davidlougheed
refact(beacon): move apiErrorMessage to BeaconQueryUi param
172d18e
@davidlougheed
lint
9118bb7
@davidlougheed
Merge remote-tracking branch 'origin/main' into refact/beacon-slices
3937c23 
# Conflicts:
#	src/js/components/Beacon/BeaconQueryUi.tsx
#	src/js/components/Search/SearchResultsPane.tsx
#	src/styles.css
@davidlougheed
lint(beacon): query UI input order
3b318c2
@davidlougheed
Merge pull request #206 from bento-platform/refact/beacon-slices
b8e8f18 
refact: combine beacon and network double-slices
davidlougheed
davidlougheed approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsfk
Copy link
Member Author

gsfk commented Oct 22, 2024

woot

@gsfk gsfk merged commit d424f18 into main Oct 22, 2024
2 checks passed
@davidlougheed davidlougheed deleted the features/beacon-network branch October 22, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsfk @davidlougheed