-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Sider #162
Site Sider #162
Conversation
SanjeevLakhwani
commented
May 16, 2024
•
edited
Loading
edited
- Added a sider that replaces the tabbed dashboard in the previous version
ea08308
to
73578a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to account for custom logos
remove extra beacon file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side menu much prettier than the old tabs!
Perhaps a little late for this question, but what's the advantage of a dynamic "sider" over a simple side menu? I would think the main use case would be the ability to show a smaller menu when the sceen is smaller, but this pr doesn't do that.
Also, since tabs are gone the pages no longer have large text showing you which tab you're on... now you have only super-small text in the side menu to know where you are. Not sure if pages need header text added or if I'm just not used to it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not totally sold on the new header text... although the text appears in the same spot for each page, the page layout isn't consistent. Overview and Provenance are aligned with the component below them:
... but Search & Beacon are not:
I also just find them ugly... I know that's not a particularly helpful comment. I wonder if this text wouldn't be better off in the header? Not sure.
# Conflicts: # src/js/components/SiteSider.tsx # src/js/index.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aesthetically, I think the bright white header text/button outlines are bit too harsh on the dark header background, but the visual hierarchy with the new sidebar being context for what page/project/dataset we are on works quite well.
maybe the contents of the sidebar should be sticky, so that we can change pages even if scrolled-down?
weird horizontal overflow/scroll, only on overview page on small screen (14" laptop)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So....
- top of the screen is black but side is white?
- current tab indicated from menu only?
... I wasn't sure where we landed on either of these issues.
The "Search" page does not behave consistently: if you load the main page and click Search it shows an overview, but it you load /search
it shows zero results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how will the new file for branding work with our existing instances that replace the logo?
I corrected the filenames to match the previous, so it should be the same as before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icon on both left and right of portal button - on left, the old icon; on right, the link icon. otherwise looks good i think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The results pane jumps when switching between "Search" and "Beacon", it should be in the same place.