Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: new card with subtitle and shadow #152

Merged
merged 10 commits into from
Mar 6, 2024
Merged

style: new card with subtitle and shadow #152

merged 10 commits into from
Mar 6, 2024

Conversation

SanjeevLakhwani
Copy link
Contributor

No description provided.

@davidlougheed davidlougheed changed the title New card with subtitle and shadow style: new card with subtitle and shadow Mar 4, 2024
davidlougheed
davidlougheed requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

factor out box shadow to constant, reduce shadow intensity and maybe spread, add shadow to last ingested boxes (+ maybe search boxes too?)

@SanjeevLakhwani
Copy link
Contributor Author

factor out box shadow to constant, reduce shadow intensity and maybe spread, add shadow to last ingested boxes (+ maybe search boxes too?)

done

davidlougheed
davidlougheed requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still missing:

  • box shadow on search box
  • box shadow on provenance data
  • probably on beacon too, idk my beacon isn't working
  • consistent box shadow for about card

src/js/components/Overview/PublicOverview.tsx Outdated Show resolved Hide resolved
src/js/constants/overviewConstants.ts Outdated Show resolved Hide resolved
davidlougheed
davidlougheed approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SanjeevLakhwani SanjeevLakhwani merged commit ab0e761 into main Mar 6, 2024
2 checks passed
@SanjeevLakhwani SanjeevLakhwani deleted the new-card branch March 6, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SanjeevLakhwani @davidlougheed