Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: responsive bar/pie charts + dependency updates #129

Merged
merged 1 commit into from
Dec 1, 2023
Merged

feat: responsive bar/pie charts + dependency updates #129

merged 1 commit into from
Dec 1, 2023

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed davidlougheed marked this pull request as ready for review November 30, 2023 21:54
@davidlougheed davidlougheed changed the title feat: responsive charts + dependency updates feat: responsive bar/pie charts + dependency updates Nov 30, 2023
@davidlougheed davidlougheed requested a review from gsfk November 30, 2023 21:56
gsfk
gsfk approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't charts 2.5.0 have responsive bar width for bar charts? Making a bar chart wider just gives me extra whitespace.

@davidlougheed
Copy link
Member Author

For me it makes it wider... did you run npm install locally if you have it in dev mode?

@gsfk
Copy link
Member

gsfk commented Dec 1, 2023

Better now after install + clean, cheers

@davidlougheed davidlougheed merged commit 9b01e20 into main Dec 1, 2023
2 checks passed
@davidlougheed davidlougheed deleted the feat/responsive-charts branch December 1, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsfk gsfk gsfk approved these changes

@SanjeevLakhwani SanjeevLakhwani Awaiting requested review from SanjeevLakhwani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlougheed @gsfk