Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for Beacon UI additions #126

Merged
merged 10 commits into from
Dec 22, 2023

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Nov 15, 2023

Translations for Beacon UI additions, French TODO

@gsfk gsfk changed the base branch from features/beacon-validation-and-errors to main December 12, 2023 14:00
@v-rocheleau v-rocheleau marked this pull request as ready for review December 19, 2023 21:30
Copy link
Member

@dbujold dbujold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few suggestions.

src/public/locales/fr/default_translation_fr.json Outdated Show resolved Hide resolved
src/public/locales/fr/default_translation_fr.json Outdated Show resolved Hide resolved
src/public/locales/fr/default_translation_fr.json Outdated Show resolved Hide resolved
src/public/locales/fr/default_translation_fr.json Outdated Show resolved Hide resolved
src/public/locales/fr/default_translation_fr.json Outdated Show resolved Hide resolved
src/public/locales/fr/default_translation_fr.json Outdated Show resolved Hide resolved
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@v-rocheleau v-rocheleau merged commit 045f4e5 into main Dec 22, 2023
2 checks passed
@v-rocheleau v-rocheleau deleted the features/new-beacon-ui-translations branch December 22, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants