feat: last ingestion time from data services #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-types with last ingestion data
davidlougheed
changed the title
v-rocheleau
requested changes
Nov 10, 2023
remove typo
v-rocheleau
approved these changes
Nov 13, 2023
davidlougheed
requested changes
Nov 14, 2023
There was a problem hiding this comment.
one slightly problematic thing here is that the counts exposed here are not censored by small cell count. for overall data types it doesn't matter too much, but maybe counts should be censored if you have the threshold in the Go server, or this field should just be deleted
davidlougheed
requested changes
Nov 16, 2023
endpoint and count value removal
davidlougheed
requested changes
Nov 17, 2023
davidlougheed
requested changes
Nov 20, 2023
davidlougheed
deleted the
features/last_data_ingestion_from_data-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the last data ingestion from WES and instead retrieve the information from gohan and katsu services /data-types