Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve provenance display across multiple facets #116

Merged
merged 32 commits into from
Oct 16, 2023

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed davidlougheed requested a review from gsfk October 16, 2023 14:06
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, no issues in testing.

  • doi / http links both working, although where an identifier exists, the title is already a clickable link. Do we need to have two links to the same thing in a single entry?
  • Looks better now without so much tag-style text layout, although some remains, and it's not clear if it was deliberate (eg "Funders" in Acknowledgements is still tag-style)

@davidlougheed davidlougheed merged commit 704ec66 into main Oct 16, 2023
2 checks passed
@davidlougheed davidlougheed deleted the chore/provenance-improvements branch October 16, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants